Ticket #1596 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Bad _getEntry call

Reported by: gracinet Assigned to: gracinet
Priority: P1 Milestone: CPS 3.4.1
Component: CPSUserFolder Version: 3.4.0
Severity: normal Keywords: directories
Cc:

Description 

    *  Module Products.CPSUserFolder.CPSUserFolder, line 548, in getGroupById

TypeError: _getEntry() takes exactly 2 arguments (3 given)

Indeed, the default value is in getEntry interface, not _getEntry

Change History

04/03/06 20:43:32 changed by gracinet

  • status changed from new to closed.
  • resolution set to worksforme.

Cannot reproduce anymore. From what I saw, the default value will never be used anyway, since we are inside a _hasEntry conditonal.

04/05/06 16:06:55 changed by gracinet

  • status changed from closed to reopened.
  • resolution deleted.

Ok, I confused kwargs and normal args when trying to reproduce in test: 

> /Users/zopes/courrier/Products/CPSUserFolder/CPSUserFolder.py(548)getGroupById()
-> group_entry = groups_dir._getEntry(groupname, default)
-> group_entry = groups_dir._getEntry(groupname, default)
(Pdb)

_getEntry seems to be really necessary here.

04/05/06 16:14:17 changed by gracinet

  • owner changed from fguillaume to gracinet.
  • status changed from reopened to new.
(Pdb) groups_dir._getEntry(groupname, default)
*** TypeError: _getEntry() takes exactly 2 arguments (3 given)

04/05/06 17:36:22 changed by gracinet

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [34936]