Ticket #1530 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Members doesn't have a 'last_login_time' or 'last_login' property anymore

Reported by: avoinea Assigned to: fguillaume
Priority: P2 Milestone: CPS 3.4.5
Component: CPSDefault Version: TRUNK
Severity: normal Keywords:
Cc:

Description

Scratch from logged_in.pt 

if first_time and dtool.members.hasEntry(member.getId()):
    mtool.createMemberArea()
    now = context.ZopeTime()
    member.setProperties(last_login_time=now, login_time=now)

1. Why setting 'last_login_time' and 'login_time' only if first time login ?

2. 'last_login_time' shouldn't be previous login time ?

- member.setProperties(last_login_time=now, login_time=now) doesn't change anything.

Change History

03/24/06 15:36:03 changed by fguillaume

Standard CMF behavior is on each login to:

  • set last_login_time to the previous login_time,
  • set login_time to the current time.

03/24/06 15:44:50 changed by ogrisel

beware: I changed that piece of code yesterday in [34693] because of #1560. But this does not fix your problem.

If we are to refactore that behavior we need integration tests to simulate the following use cases :

  • user that is in the members dir with role Member (first login / second login)
  • user that is in the members dir but without the Member role (first login / second login)
  • user that is not in the members dir but that has the Manager role (ie Zope admin)

05/19/06 17:03:40 changed by sfermigier

  • milestone changed from CPS 3.4.1 to CPS 3.4.2.

05/23/07 17:23:31 changed by madarche

  • priority changed from P1 to P2.
  • status changed from new to closed.
  • version changed from 3.4.0 to TRUNK.
  • resolution set to fixed.

Fixed in changeset [51776].

05/23/07 17:24:42 changed by madarche

  • milestone changed from CPS 3.5.0 to CPS 3.4.5.