Ticket #1529 (new defect)

Opened 3 years ago

Last modified 2 years ago

GenericSetup export doesn't specify the encoding

Reported by: gracinet Assigned to: fguillaume
Priority: P1 Milestone: CPS 3.5.0
Component: CPS (global) Version: TRUNK
Severity: major Keywords: GenericSetup charset
Cc:

Description

...but non-ascii chars break some xml files (expat error on import, xmllint confirms invalidity). After the encoding specification has been manually added, the problem vanishes. Example:

-<?xml version="1.0"?>
+<?xml version="1.0" encoding="iso-8859-15"?>
 <object name="1984543535" meta_type="Palette Color">
  <property name="title">Bleu Foncé</property>

Change History

03/22/06 17:06:18 changed by janguenot

  • severity changed from normal to major.

03/22/06 17:15:21 changed by gracinet

  • version changed from 3.0.0 to TRUNK.

According to Florent's comment about another issue, the point is that CPSSkins exporter should export in utf-8

03/23/06 10:16:36 changed by jmorliaguet

but the exporter simply calls _extractProperties from PropertyManagerHelpers? which comes from GenericSetup?

03/23/06 11:30:17 changed by gracinet

And PropertyManageHelper explicitely encodes in utf-8 on *importation* only, as far as I can see... I don't know what it's supposed to do.

I checked that the issue's still there (copy paste from my version of less that shows hexadecimal codes for non-ascii chars):

<?xml version="1.0"?>
<object name="Default" meta_type="Theme Page">
 <property name="title">D<E9>faut</property>

And this is definitely not cpsskin's fault: {{{<?xml version="1.0"?> <object name="document" meta_type="CPS Layout">

<property name="layout_create_method"></property> <property name="layout_edit_method"></property> <property name="layout_view_method"></property> <property name="style_prefix">layout_default_</property> <property name="flexible_widgets"/> <property name="validate_values_expr"></property> <widget name="content" meta_type="Text Widget">

<property name="title">Accentu<E9></property>

}}}

05/19/06 17:08:53 changed by sfermigier

  • milestone changed from CPS 3.4.1 to CPS 3.4.2.