Ticket #1269 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

slot layout : horizontal menu too strong

Reported by: tsoulcie Assigned to: jmorliaguet avoinea
Priority: P1 Milestone: CPS 3.4.0
Component: CPSSkins Version: 3.3.8
Severity: minor Keywords:
Cc: tsoulcie@nuxeo.com

Description

When formatting a portal box group templet, you can't align it to right if "horizontal menu" is chosen. Why couldn't a horizontal portal be aligned to right ? ... May be a css conflict, dunno but it would be nice to have it fixed for the release :-)

Change History

01/24/06 18:30:13 changed by ogrisel

Obviously the tabs rendering mode for portlet slots (that defines the .cpsskinsTabs class in the CSS) is based upon the sliding doors:

http://www.alistapart.com/articles/slidingdoors

Unfortunately this prevents the contextual 'text-align' rule to work since the technique uses a combination of hard-coded "float: left" and "display: block" rules for "li" and "a" tags.

It is possible to get the 'float: left' dynamically translated into a 'float-right' if the slot layout is set to right align but this will change the ordering of items. Plus float:center does not work and it's not that easy to make 'float: left' items centered.

What could be done is use 'display: inline' rules without float instead, much the way the .cpsskinsTab class is defined. This kind of work but need additional testing though.

What we might loose:

  • the bottom border line (maybe this can be readded in another way)
  • recode the horizontal margins stuff

What we gain:

  • a natural way to align the tabs

Open question:

  • How to implement this?

In a brand new render mode with a new CSS class with and associated brand new tab style? Reusing .cpsskinsTab class by upgrading it to work background images ?

It is probably not possible to modify the existing .cpsskinsTabs class and related tab style system to get rid of the float based system without breaking backward compatibility thus we'll have to find another way.

01/24/06 19:31:26 changed by jmorliaguet

I'm for adding a new layout. The current CPSSkins box layout implementation supports as many layouts as needed. The reason for that is that new CSS layout techniques are discovered all the time.

if you find a pointer to a technique that works (without float:left), it is very easy to add it.

see CPSSkins.SimpleBox? for the list of available layouts.

considering the box style (tab images, etc.) I suppose that the same PortalTab? style can be used.

01/24/06 20:01:50 changed by ogrisel

  • owner changed from jmorliaguet to ogrisel.

ok then. I'm away till the end of the week but I'll try to implement that in a new layout next week.

02/21/06 11:51:46 changed by tsoulcie

  • owner changed from ogrisel to jmorliaguet avoinea.

02/21/06 18:02:01 changed by avoinea

  • status changed from new to closed.
  • resolution set to fixed.

Fixed by revision [33255]

02/21/06 21:14:07 changed by avoinea

Updated (revision [33261]) to work with portal_tabs, too.